Skip to content

fix: add Deepin to OnlyShowIn in dde-lock desktop entry - #98

Merged
wjyrich merged 1 commit into
linuxdeepin:masterfrom
wjyrich:fix-bug-378247
Sep 24, 2026
Merged

fix: add Deepin to OnlyShowIn in dde-lock desktop entry#98
wjyrich merged 1 commit into
linuxdeepin:masterfrom
wjyrich:fix-bug-378247

Conversation

@wjyrich

@wjyrich wjyrich commented Sep 24, 2026 •
edited by sourcery-ai Bot
Loading

Copy link
Copy Markdown
Contributor
  1. Update OnlyShowIn field from DDE to DDE;Deepin in dde-lock.desktop
  2. Ensure the lock screen application is recognized under the Deepin desktop environment
  3. Improve desktop session compatibility so dde-lock displays correctly when the session is identified as Deepin rather than DDE

Influence:

  1. Verify dde-lock appears and functions under the Deepin session
  2. Confirm dde-lock still works correctly under the DDE session
  3. Test lock screen triggering and unlocking on both session identifiers
  4. Verify no regression in desktop entry parsing or application launching

fix: 在 dde-lock 桌面条目中为 OnlyShowIn 添加 Deepin

  1. 将 dde-lock.desktop 中的 OnlyShowIn 字段从 DDE 更新为 DDE;Deepin
  2. 确保锁屏应用在 Deepin 桌面环境下也能被识别
  3. 提升桌面会话兼容性，使 dde-lock 在会话标识为 Deepin 而非 DDE 时也能正 常显示

Influence:

  1. 验证在 Deepin 会话下 dde-lock 能正常显示和运行
  2. 确认在 DDE 会话下 dde-lock 仍能正常工作
  3. 在两种会话标识下测试锁屏触发和解锁流程
  4. 验证桌面条目解析和应用启动无回归问题

PMS: BUG-378247

Summary by Sourcery

Bug Fixes:

  • Allow dde-lock to be recognized and displayed in Deepin sessions while preserving support for DDE sessions.

@wjyrich
fix: add Deepin to OnlyShowIn in dde-lock desktop entry
5ec6da0 
1. Update OnlyShowIn field from DDE to DDE;Deepin in dde-lock.desktop
2. Ensure the lock screen application is recognized under the Deepin
desktop environment
3. Improve desktop session compatibility so dde-lock displays correctly
when the session is identified as Deepin rather than DDE

Influence:
1. Verify dde-lock appears and functions under the Deepin session
2. Confirm dde-lock still works correctly under the DDE session
3. Test lock screen triggering and unlocking on both session identifiers
4. Verify no regression in desktop entry parsing or application
launching

fix: 在 dde-lock 桌面条目中为 OnlyShowIn 添加 Deepin

1. 将 dde-lock.desktop 中的 OnlyShowIn 字段从 DDE 更新为 DDE;Deepin
2. 确保锁屏应用在 Deepin 桌面环境下也能被识别
3. 提升桌面会话兼容性，使 dde-lock 在会话标识为 Deepin 而非 DDE 时也能正
常显示

Influence:
1. 验证在 Deepin 会话下 dde-lock 能正常显示和运行
2. 确认在 DDE 会话下 dde-lock 仍能正常工作
3. 在两种会话标识下测试锁屏触发和解锁流程
4. 验证桌面条目解析和应用启动无回归问题

PMS: BUG-378247
@sourcery-ai

sourcery-ai Bot commented Sep 24, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the dde-lock desktop entry’s OnlyShowIn field from DDE to DDE;Deepin so the lock-screen application is recognized and launched in both desktop session identifiers without changing its implementation.

File-Level Changes

Change Details Files
Expand desktop-environment visibility for the lock-screen desktop entry.
  • Update the OnlyShowIn value to include both DDE and Deepin sessions.
  • Preserve availability under the existing DDE session identifier while adding Deepin compatibility.
 files/snipe/dde-lock.desktop
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-ci-robot deepin-ci-robot mentioned this pull request Sep 24, 2026
Open
sourcery-ai[bot]
sourcery-ai Bot reviewed Sep 24, 2026
View reviewed changes

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@wjyrich

wjyrich commented Sep 24, 2026

Copy link
Copy Markdown
Contributor Author

/test

@deepin-ci-robot

deepin-ci-robot commented Sep 24, 2026

Copy link
Copy Markdown

@wjyrich: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

  • /test deepin-auto-translation
  • /test github-pr-review-ci

Use /test all to run the following jobs that were automatically triggered:

  • github-pr-review-ci
Details

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@deepin-ci-robot

deepin-ci-robot commented Sep 24, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mhduiy, wjyrich

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wjyrich
wjyrich merged commit b34f0d4 into linuxdeepin:master Sep 24, 2026
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments
@mhduiy mhduiy mhduiy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wjyrich @deepin-ci-robot @mhduiy